-
Notifications
You must be signed in to change notification settings - Fork 16
feat(plugin-eslint): add setup wizard binding #1269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f493911
refactor: extract plugin setup types to models
hanna-skryl 059fcde
build: allow tooling to depend on all scopes
hanna-skryl 0b4c70b
feat(plugin-eslint): add setup wizard binding
hanna-skryl a23ed2d
refactor(plugin-eslint): improve plugin setup binding
hanna-skryl 908a091
Merge branch 'main' into eslint-plugin-binding
hanna-skryl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| import type { CategoryConfig } from './category-config.js'; | ||
| import type { PluginMeta } from './plugin-config.js'; | ||
|
|
||
| type PromptBase = { | ||
| key: string; | ||
| message: string; | ||
| }; | ||
|
|
||
| type PromptChoice<T extends string> = { name: string; value: T }; | ||
|
|
||
| type InputPrompt = PromptBase & { | ||
| type: 'input'; | ||
| default: string; | ||
| }; | ||
|
|
||
| type SelectPrompt<T extends string = string> = PromptBase & { | ||
| type: 'select'; | ||
| choices: PromptChoice<T>[]; | ||
| default: T; | ||
| }; | ||
|
|
||
| type CheckboxPrompt<T extends string = string> = PromptBase & { | ||
| type: 'checkbox'; | ||
| choices: PromptChoice<T>[]; | ||
| default: T[]; | ||
| }; | ||
|
|
||
| /** Declarative prompt definition used to collect plugin-specific options. */ | ||
| export type PluginPromptDescriptor = | ||
| | InputPrompt | ||
| | SelectPrompt | ||
| | CheckboxPrompt; | ||
|
|
||
| export type ImportDeclarationStructure = { | ||
| moduleSpecifier: string; | ||
| defaultImport?: string; | ||
| namedImports?: string[]; | ||
| isTypeOnly?: boolean; | ||
| }; | ||
|
|
||
| /** Import declarations and plugin initialization code produced by `generateConfig`. */ | ||
| export type PluginCodegenResult = { | ||
| imports: ImportDeclarationStructure[]; | ||
| pluginInit: string; | ||
| categories?: CategoryConfig[]; | ||
| }; | ||
|
|
||
| /** | ||
| * Defines how a plugin integrates with the setup wizard. | ||
| * | ||
| * Each supported plugin provides a binding that controls: | ||
| * - Pre-selection: `isRecommended` detects if the plugin is relevant for the repository | ||
| * - Configuration: `prompts` collect plugin-specific options interactively | ||
| * - Code generation: `generateConfig` produces the import and initialization code | ||
| */ | ||
| export type PluginSetupBinding = { | ||
| slug: PluginMeta['slug']; | ||
| title: PluginMeta['title']; | ||
| packageName: NonNullable<PluginMeta['packageName']>; | ||
| scope?: 'project' | 'root'; | ||
| prompts?: (targetDir: string) => Promise<PluginPromptDescriptor[]>; | ||
| isRecommended?: (targetDir: string) => Promise<boolean>; | ||
| generateConfig: ( | ||
| answers: Record<string, string | string[]>, | ||
| ) => PluginCodegenResult; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.