Try to fail silently on Soup attribute errors#79
Open
GVRV wants to merge 1 commit intocobrateam:masterfrom
Open
Try to fail silently on Soup attribute errors#79GVRV wants to merge 1 commit intocobrateam:masterfrom
GVRV wants to merge 1 commit intocobrateam:masterfrom
Conversation
Member
|
@GVRV thank you. Can you add some tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting errors like the following when trying to minify a few email templates within celery tasks (to avoid clipping by GMail).
AttributeError: 'NavigableString' object has no attribute 'name'AttributeError: 'Comment' object has no attribute 'name'Tried to silence these errors by using
getattr, so in the worst case, we're failing silently instead of blowing up.