fix: provide SOA record in zone transfer server for compatibility with CoreDNS#427
Open
pulsastrix wants to merge 1 commit intocmur2:masterfrom
Open
fix: provide SOA record in zone transfer server for compatibility with CoreDNS#427pulsastrix wants to merge 1 commit intocmur2:masterfrom
pulsastrix wants to merge 1 commit intocmur2:masterfrom
Conversation
After receiving a NOTIFY, some DNS servers (e.g., CoreDNS) first check the SOA record for changes to the serial number before performing a zone transfer. If no SOA record is provided, CoreDNS assumes the zonefile to be unchanged and does not update its copy of the zone. This commit ensures compatibility with CoreDNS (and similarly acting DNS servers) by supporting SOA record requests in the zone transfer server.
pulsastrix
changed the title
Owner
|
@pulsastrix thank you for this PR, I really wasn't expecting anyone to notice my little project at this stage 😅 I just enabled a run of the CI, and it is failing with some nitpicks on the linter. I currently don't have the capacity to look at this change deeper: it sounds good but I need time to assess it doesn't break anything existing, e.g. for my own setup relying on the updater ^^ One thing I could offer is: updaters are modular, so it would be possible to instead of modifying |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After receiving a NOTIFY, some DNS servers (e.g., CoreDNS) first check the SOA record for changes to the serial number before performing a zone transfer. If no SOA record is provided, CoreDNS assumes the serial number (and therefore the Zone file) to be unchanged and does not update its copy of the zone.
This PR ensures compatibility with CoreDNS (and similarly acting DNS servers) by supporting SOA record requests in the zone transfer server.