Skip to content

Phase2-hgx365X Allow creation of scintillator SimHits in the V19 version of the HGCal geometry#50530

Open
bsunanda wants to merge 3 commits intocms-sw:masterfrom
bsunanda:Phase2-hgx365X
Open

Phase2-hgx365X Allow creation of scintillator SimHits in the V19 version of the HGCal geometry#50530
bsunanda wants to merge 3 commits intocms-sw:masterfrom
bsunanda:Phase2-hgx365X

Conversation

@bsunanda
Copy link
Copy Markdown
Contributor

PR description:

Allow creation of scintillator SimHits in the V19 version of the HGCal geometry

PR validation:

Tested using scripts in SimG4CMS/Calo/test/python

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 25, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50530/48705

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Geometry/HGCalCommonData (geometry)
  • SimG4CMS/Calo (simulation)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks.
@ReyerBand, @fabiocos, @felicepantaleo, @martinamalberti, @rovere, @slomeo, @thomreis, @wang0jin this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Copy Markdown
Contributor Author

@cmsbuild Please test

@bsunanda
Copy link
Copy Markdown
Contributor Author

type Bug Fix

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61ae45/52227/summary.html
COMMIT: 0bb2e69
CMSSW: CMSSW_16_1_X_2026-03-24-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50530/52227/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4185300
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4185266
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Copy Markdown
Contributor Author

+geometry

@bsunanda
Copy link
Copy Markdown
Contributor Author

Type bugfix

@civanch
Copy link
Copy Markdown
Contributor

civanch commented Mar 27, 2026

+1

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants