L1S(Nano): updates for 2026 data-taking (CaloTowers, Scenario)#50510
Merged
cmsbuild merged 8 commits intocms-sw:masterfrom Mar 26, 2026
Merged
L1S(Nano): updates for 2026 data-taking (CaloTowers, Scenario)#50510cmsbuild merged 8 commits intocms-sw:masterfrom
cmsbuild merged 8 commits intocms-sw:masterfrom
Conversation
…=True This changes the initialisation of the vector "selbxOffsets", which is used in case the parameter "skipNonExistingSrc" is set to True. Without this change, that vector is empty, and this leads to a segmentation fault at https://github.com/cms-sw/cmssw/blob/edd2f62bfb3fe43fdc5609ce38b82169e80251fb/DataFormats/NanoAOD/interface/OrbitFlatTable.h#L27
Updates to add CaloTowers' information to the output of "L1ScoutingNano" for 2026 workflows. This is done by adding a modifier named "run3_l1scouting_2026", and including it in the Era "Run3_2026". Various updates are made to custom_l1scoutingrun3_cff, mainly - using a dedicated Sequence (rather than overriding the regular NANO sequence), and - making the customisation of the relevant output module(s) more robust (covering both the NANOEDMAOD and NANOAOD data tiers, and not relying solely on the label of the output module). Co-Authored-By: Rocco Ardino <rocco.ardino@cern.ch>
This change adds wfs to test on real data the NANOAOD flavours "L1Scout" and "L1ScoutSelect" for the Eras "Run3_2025" and "Run3_2026".
…a to EventContent_cff The EventContents (incl. compression settings) of Run-3 L1-Scouting data for the NANO(EDM)AOD data tiers are now defined in a dedicated file [1], and the latter file is imported by [2], following what is done for other EventContents used in "central production". The implementation of the L1-Scouting NANOAOD flavours is updated accordingly (removing explicit "keep/drop statements" from the relevant customisation functions). [1] PhysicsTools/NanoAOD/python/L1SCOUTNanoAODEDMEventContent_cff.py [2] Configuration/EventContent/python/EventContent_cff.py
This adds a scenario named "l1ScoutingEra_Run3_2026", in order to produce "L1ScoutingNano" data sets at Tier-0 in 2026. This closely resembles what has been done for HLT-Scouting since 2024, see for example cms-sw#44970
This updates the "mergeProcess" function in Merge.py in order to support the merging of NanoEDMAOD files for Run-3 L1-Scouting data. Creating flat NanoAOD files from NANOEDMAOD files of Run-3 L1-Scouting data requires using the plugin "OrbitNanoAODOutputModule" (instead of "NanoAODOutputModule"). "OrbitNanoAODOutputModule" converts orbit-based NanoAOD tables (EDM) to event/BX-based "flat" NanoAOD branches. See dmwm/WMCore#12485 for related updates to the WMCore package.
This updates the content of the NanoAOD flavour for L1-Scouting data
in order to use the same branch names and data types as those used
in the NanoAOD flavour used for the L1T-DPG studies ("L1DPG").
Contributor
|
cms-bot internal usage |
This was referenced Mar 24, 2026
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50510/48677
|
Contributor
|
A new Pull Request was created by @missirol for master. It involves the following packages:
@AdrianoDee, @DickyChant, @antoniovagnerini, @battibass, @cmsbuild, @davidlange6, @emeschi, @fabiocos, @ftenchini, @ftorrresd, @mandrenguyen, @miquork, @smorovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
|
enable nano |
Contributor
|
please test |
Contributor
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
Nano size comparison Summary:
NANO Comparison SummarySummary:
|
Contributor
|
-1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
Nano size comparison Summary:
NANO Comparison SummarySummary:
|
Contributor
Author
|
Mh, "DAS error" in wf Edit : the corresponding tests of the 16_0_X backport (#50511 (comment)) passed without errors, suggesting that the issue with wf |
Contributor
|
+daq |
Contributor
|
ignore tests-rejected with manual-override |
cmsbuild
added
operations-approved
tests-approved
tests-manual-override
and removed
operations-pending
tests-rejected
labels
Contributor
|
urgent |
Contributor
|
Thanks for the PR. We (XPOG) have two comments: 1 - This PR is addressing 6 related but different businesses at the same time. This makes reviewing much harder. Maybe atomics are better for future PRs. 2 - Looks like the L1Scouting code is duplicating modules and functionalities around the NanoAOD infrastructure, which could be potentially hard to maintain in the future (as already mentioned at #48163 (comment) ). Maybe time has come to have further discussions on this, in order to understand the impact and refactor these duplications, if it makes sense. Would you mind preparing a few slides to steer a conversation about it at the next XPOG meeting? |
Contributor
|
+1 |
cmsbuild
added
fully-signed
xpog-approved
and removed
pending-signatures
xpog-pending
labels
Contributor
|
This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Contributor
Author
|
Hi @ftorrresd, thanks, some replies below.
I'd agree that separating changes across multiple PRs is usually a good way to go, but then the review needs to be faster. My attempt to factorise was to open #50374 (and its backport) 2 weeks ago, but that went basically un-reviewed by XPOG, so I decided to go for a single PR this time.
Sure. This discussion is new to me, and I can't really comment on the specifics. Maybe it's useful to open an issue in CMSSW about this, and have XPOG and other sw experts define there..
Sure. When exactly ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
This PR implements several updates to the NanoAOD flavours for L1-Scouting data (introduced in #48163) for 2026 data-taking.
relvals_nano.pyto test the L1-Scouting NanoAOD flavours for the Run-3 2025 and 2026 eras.SimpleOrbitFlatTableProducerfor a case which is not currently used in any central workflows (see the commit message of the relevant commit for more info).L1ScoutingEtSumOrbitFlatTableProduceraffecting the content of two NanoAOD 'branches' (the EtSum pt/phi hardware values were mistakenly being filled with the pt/phi physical values).isL1Scoutingto themergeProcessfunction; the latter function is used by T0/WMCore to build the configuration for the "merge" step of the outputs of CMSSW jobs.The latter update to the "merge" step is meant to support a feature specific to the L1-Scouting NanoAOD flavour, which is that the conversion from NanoAOD EDM files to "flat" NanoAOD ntuples needs to be done with the plugin
OrbitNanoAODOutputModule(instead ofNanoAODOutputModule) in order to convert orbit-based EDM tables to flat (BX-based) output branches (the terminology I used might be imprecise, but that's the idea). The corresponding update toWMCoreis dmwm/WMCore#12485.The original version of this PR was in #50374, it included only the first 3 points of the list above. It was not reviewed timely, and it ended up being replaced by this PR.
PR validation:
The L1ScoutingNano-related workflows pass (both the existing ones and the new ones).
The unit test related to the new Scenario for L1-Scouting passed.
The additional test in [*] runs as expected (compared to the matrix wfs, this one also tests the
NANOEDMAODevent content, and the conversion fromNANOEDMAODtoNANOAODusing the scriptRunMerge.py).If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
CMSSW_16_0_XTo be backported to
16_0_Xin an attempt to run the NanoAOD step on L1-Scouting data at T0 during 2026 data-taking.[*]