Validation/SiTrackerPhase2V: Streamline validation code and add necessary histograms#50502
Validation/SiTrackerPhase2V: Streamline validation code and add necessary histograms#50502brandiskip wants to merge 32 commits intocms-sw:masterfrom
Conversation
…e in Phase2OTEffClient_cff.py
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50502/48667 ERROR: Unable to merge PR. See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50502/48667/cms-checkout-topic.log |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50502/48668 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50502/48669 |
|
Pull request #50502 was updated. |
| trackParts_Eta = book1DFromPS(iBooker, "trackParts_Eta", psTrackParts_Eta, "#eta", "# tracking particles"); | ||
| trackParts_Phi = book1DFromPS(iBooker, "trackParts_Phi", psTrackParts_Phi, "#phi", "# tracking particles"); | ||
| trackParts_Num = | ||
| book1DFromPS(iBooker, "trackParts_Num", n_trackParticles, "# track particles per event", "# tracking particles"); |
There was a problem hiding this comment.
Checking this branch using the RelVal GUI, n_trackParts has been renamed trackParts_Num which is preventing it showing up in the Quick Collection. I actually think that trackParts_Num is the better name for this histogram, so I am open to changing the DQMGUI PR to pick this one up. I'll ping it up on mattermost.
There was a problem hiding this comment.
Thanks @ljuckett, I did change the name to fit with the naming conventions of other track params
3 participants
Replaced Phase2OTHarvestStub.cc with the Python configuration Phase2OTEffClient_cff.py to calculate efficiencies using DQMGenericClient::computeEfficiency.
Updated TrackerPhase2HistUtil.h with new helper functions for booking and filling resolution histograms, which removes hundreds of lines of repetitive C++ code.
Added event weights to Phase2OTValidateStub.cc.
Added new histograms for the number of stubs, Delta r (for 2S and PS modules), and Delta bend (for 2S and PS modules in the barrel and endcaps).
Organized the stub directory structure by moving 40 detailed residual histograms into a new Residual/Detailed subfolder. Users will see the new stub histograms in the DQM output. The detailed residual plots are now nested under the Residual/Detailed directory to declutter the main DQM workspace.
For more details, see slides found here. Overall, this PR eliminates a few thousand lines of code by using DQMGenericClient and C++ helper functions to reduce redundancy.
Histograms can be reviewed here under TrackerPhase2OTL1TrackV and TrackerPhase2OTStubV.
PR validation:
scram build code-checks
scram build code-format