Skip to content

L1S(Nano): add CaloTowers to 2026 "L1ScoutingNano" workflows [16_0_X]#50375

Closed
missirol wants to merge 3 commits intocms-sw:CMSSW_16_0_Xfrom
missirol:devel_l1sNanoCaloTowersFor2026
Closed

L1S(Nano): add CaloTowers to 2026 "L1ScoutingNano" workflows [16_0_X]#50375
missirol wants to merge 3 commits intocms-sw:CMSSW_16_0_Xfrom
missirol:devel_l1sNanoCaloTowersFor2026

Conversation

@missirol
Copy link
Contributor

backport of #50374

PR description:

From the description of #50374:

This PR (based on work by @RoccoA97) updates the NANO flavours for L1-Scouting data (introduced in #48163) in order to include CaloTowers for 2026-related workflows.

This is done by creating the modifier run3_l1scouting_2026, and including it in the definition of the Era Run3_2026.

Workflows to test the L1Scout and L1ScoutSelect NANO flavours for the Eras Run3_2025 and Run3_2026 are also added.

In addition, 3716d18 includes a small bugfix to the plugin SimpleOrbitFlatTableProducer for a case which is not currently used in any central workflows (see the commit message for more info).

PR validation:

None beyond the checks made for #50374 (see description of that PR).

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#50374

To facilitate private validation studies on 2026 L1-Scouting data (and maybe as a first step to eventually produce this NANO flavour "centrally" in some way, yet to be determined).

…=True

This changes the initialisation of the vector "selbxOffsets",
which is used in case the parameter "skipNonExistingSrc" is set to True.
Without this change, that vector is empty, and this leads to a segmentation fault at
https://github.com/cms-sw/cmssw/blob/edd2f62bfb3fe43fdc5609ce38b82169e80251fb/DataFormats/NanoAOD/interface/OrbitFlatTable.h#L27
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2026

A new Pull Request was created by @missirol for CMSSW_16_0_X.

It involves the following packages:

  • Configuration/Eras (operations)
  • Configuration/PyReleaseValidation (pdmv)
  • L1TriggerScouting/Utilities (daq)
  • PhysicsTools/NanoAOD (xpog)

@AdrianoDee, @DickyChant, @antoniovagnerini, @battibass, @cmsbuild, @davidlange6, @emeschi, @fabiocos, @ftenchini, @ftorrresd, @mandrenguyen, @miquork, @smorovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @Mmiglio, @fabiocos, @gpetruc, @makortel, @mmusich, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2026

cms-bot internal usage

missirol and others added 2 commits March 16, 2026 08:09
Updates to add CaloTowers' information to the output
of "L1ScoutingNano" for 2026 workflows.

This is done by adding a modifier named "run3_l1scouting_2026",
and including it in the Era "Run3_2026".

Various updates are made to custom_l1scoutingrun3_cff, mainly
 - using a dedicated Sequence (rather than overriding the regular NANO sequence), and
 - making the customisation of the relevant output module(s) more robust
   (covering both the NANOEDMAOD and NANOAOD data tiers, and
   not relying solely on the label of the output module).

Co-Authored-By: Rocco Ardino <rocco.ardino@cern.ch>
This change adds wfs to test on real data
the NANOAOD flavours "L1Scout" and "L1ScoutSelect"
for the Eras "Run3_2025" and "Run3_2026".
@missirol missirol force-pushed the devel_l1sNanoCaloTowersFor2026 branch from df11e0b to 4ed73ca Compare March 16, 2026 07:10
@cmsbuild
Copy link
Contributor

Pull request #50375 was updated. @AdrianoDee, @DickyChant, @antoniovagnerini, @battibass, @cmsbuild, @davidlange6, @emeschi, @fabiocos, @ftenchini, @ftorrresd, @mandrenguyen, @miquork, @smorovic can you please check and sign again.

@smorovic
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9faefd/52050/summary.html
COMMIT: 4ed73ca
CMSSW: CMSSW_16_0_X_2026-03-17-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50375/52050/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4166533
  • DQMHistoTests: Total failures: 61
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4166452
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

As expected, I don't see anything problematic in the outputs of the PR tests (DQM discrepancies for wf 34634.999 are related to #47071).

@smorovic
Copy link
Contributor

+daq

@missirol
Copy link
Contributor Author

Superseded by #50511.

@missirol missirol closed this Mar 24, 2026
@missirol missirol deleted the devel_l1sNanoCaloTowersFor2026 branch March 24, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants