Dynamic module veto list for pixel cluster counting lumi

[nowaythatsok]

Dear Colleagues,
this is my first contribution to the CMSSW codebase. I tried to get it in as good a shape as I could, but now it is time to make the PR. Thank you for your input in advance.

I tried to rebase my commits onto master as per the recommendations. 3 commits showed merge conflicts in files I never touched. I pulled the current version of the files from master to fix that.

git checkout official-cmssw/master -- Configuration/Geometry/README.md
git checkout official-cmssw/master -- Configuration/Geometry/python/dict2021Geometry.py
git checkout official-cmssw/master -- Configuration/StandardSequences/python/GeometryConf.py
git checkout official-cmssw/master -- Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2025.xml
git checkout official-cmssw/master -- Geometry/CMSCommonData/python/cmsExtendedGeometry2025XML_cfi.py
git checkout official-cmssw/master -- GeneratorInterface/LHEInterface/data/run_generic_tarball_cvmfs.sh
git checkout official-cmssw/master -- L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.cc

git add --sparse     Configuration/Geometry/README.md Configuration/Geometry/python/dict2021Geometry.py Configuration/StandardSequences/python/GeometryConf.py Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2025.xml Geometry/CMSCommonData/python/cmsExtendedGeometry2025XML_cfi.py GeneratorInterface/LHEInterface/data/run_generic_tarball_cvmfs.sh L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.cc

PR description:

These changes implement a per-run dynamic selection of the tracker modules based on certain stability criteria for more robust luminosity measurement. The algorithm is described in more detail here.

The feature also implements a new record in the ALCA Conditions DB to keep note of the vetoed modules. The details of this were discussed here.

The record data structure is also used as a volatile/transient structure passed between producers. Not to repeat code, I just included the class defined in src/CondFormats/Luminosity/interface/PccVetoList.h to src/DataFormats/Luminosity/interface/PccVetoListTransient.h, I hope this is good enough practice.

The total feature is not activated in the configs, for now the point is to add it to the codebase.

PR validation:

Current tests are here for Run2 and here for Run3 files.
I am not familiar with tests in "the matrix", here some advice would be welcome.

@capalmer85 @duff-ae @brkronheim

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48861/46023

• Found files with invalid states:
  • Calibration/LumiAlCaRecoProducers/python/rawPCC.csv:
    • Added: 5a592cf
    • Deleted: a4ee997
  • Calibration/LumiAlCaRecoProducers/plugins/DynamicVetoProducer_old.cc:
    • Added: 05d44e1
    • Deleted: c7eb2d1
  • Calibration/LumiAlCaRecoProducers/python/PCC_Run3.root:
    • Added: 5a592cf
    • Deleted: 05d44e1
  • Calibration/LumiAlCaRecoProducers/plugins/DynamicVetoProducer.bckp:
    • Added: 5a592cf
    • Deleted: c7eb2d1
  • Calibration/LumiAlCaRecoProducers/plugins/try.something:
    • Added: 5a592cf
    • Deleted: c7eb2d1
  • Calibration/LumiAlCaRecoProducers/notes.md:
    • Added: 5a592cf
    • Deleted: 7267bc5

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48861/46023/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48861/46023/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48861/46023/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48861/46023/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48861/46037

[cmsbuild]

Pull request #48861 was updated. @arunhep, @atpathak, @cmsbuild, @francescobrivio, @jfernan2, @mandrenguyen, @perrotta can you please check and sign again.

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_16_0_X. Please open a backport if it should also go in to CMSSW_15_1_X.

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_16_1_X. Please open a backport if it should also go in to CMSSW_16_0_X.

[perrotta]

-1

• This is just to keep this PR out of our (AlCa+DB) radars.
• Of course, as soon as @nowaythatsok or anyone else will pick up the PR again, we will continue the review and the discussion about it