build: pin net6 package dependencies to 8.0.0#10
Open
iamherrylok wants to merge 1 commit intoclowd:masterfrom
Open
build: pin net6 package dependencies to 8.0.0#10iamherrylok wants to merge 1 commit intoclowd:masterfrom
iamherrylok wants to merge 1 commit intoclowd:masterfrom
Conversation
Member
|
Hey, thanks for the contribution. Not sure I entirely understand why this is necessary? Your entire PR description (including the Why) talks about what was done rather than why it is needed. |
Author
|
hello caesay, sorry that my earlier description wasn’t very clear. When using Clowd.Clipboard.Gdi in a .NET 6 project, I consistently get warnings because System.Drawing.Common 9.0.0 and System.Text.Encoding.CodePages 9.0.0 are no longer supported on net6.0. This PR pins those dependencies to version 8.0.0 when targeting .NET 6 in order to eliminate those warnings and keep the package compatible with that target framework. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adjusts package versions specifically for .NET 6 targets while keeping current versions for newer frameworks.
Changes
src/Clowd.Clipboard/Clowd.Clipboard.csprojSystem.Text.Encoding.CodePages8.0.0 whenTargetFrameworkstarts withnet6.0(covers bothnet6.0andnet6.0-windows).System.Text.Encoding.CodePages9.0.0 for non-.NET 6 target frameworks.src/Clowd.Clipboard.Gdi/Clowd.Clipboard.Gdi.csprojSystem.Drawing.Common8.0.0 whenTargetFrameworkstarts withnet6.0(covers bothnet6.0andnet6.0-windows).System.Drawing.Common9.0.0 for non-.NET 6 target frameworks (excludingnet461as before).Why
.NET 6 targets should consume dependency versions aligned with the .NET 8 package line (
8.0.0) rather than9.0.0.This keeps behavior for .NET 8+ targets unchanged while improving compatibility and clarity for .NET 6 target selection.
Notes
StartsWith("net6.0")to cover bothnet6.0andnet6.0-windowsin a single expression.