chore: Adjust plugin imports to only load metrics from the toolkit#4213
Merged
chore: Adjust plugin imports to only load metrics from the toolkit#4213
Conversation
mxschll
reviewed
Jan 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4213 +/- ##
==========================================
+ Coverage 97.16% 97.17% +0.01%
==========================================
Files 879 882 +3
Lines 25780 25826 +46
Branches 9328 9331 +3
==========================================
+ Hits 25049 25097 +48
+ Misses 725 723 -2
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
422bc27 to
a194f72
Compare
pan-kot
commented
Jan 28, 2026
| "sass": "^1.89.2", | ||
| "sass-loader": "^12.3.0", | ||
| "size-limit": "^11.1.6", | ||
| "size-limit": "^12.0.0", |
Member
Author
There was a problem hiding this comment.
note: This change is technically not needed, but let's keep it.
It was a dependency of @size-limit/esbuild-why which I used to create the graphs.
mxschll
approved these changes
Jan 28, 2026
Who-is-PS
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is required for cloudscape-design/component-toolkit#190
The plugin code is updated to import metrics from /internal to /internal/metrics to not pull unneeded code in.
How has this been tested?
I tested that by installing this version of the toolkit: cloudscape-design/component-toolkit#190
Without change (all /internal deps is pulled in including react imports):
With change:
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.