Skip to content

Comments

chore: Adjust plugin imports to only load metrics from the toolkit#4213

Merged
pan-kot merged 1 commit intomainfrom
size-limit-12
Jan 28, 2026
Merged

chore: Adjust plugin imports to only load metrics from the toolkit#4213
pan-kot merged 1 commit intomainfrom
size-limit-12

Conversation

@pan-kot
Copy link
Member

@pan-kot pan-kot commented Jan 28, 2026

Description

This is required for cloudscape-design/component-toolkit#190

The plugin code is updated to import metrics from /internal to /internal/metrics to not pull unneeded code in.

How has this been tested?

I tested that by installing this version of the toolkit: cloudscape-design/component-toolkit#190

Without change (all /internal deps is pulled in including react imports):

Screenshot 2026-01-28 at 15 00 27

With change:

Screenshot 2026-01-28 at 14 59 45
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot requested a review from a team as a code owner January 28, 2026 13:06
@pan-kot pan-kot requested review from Who-is-PS and removed request for a team January 28, 2026 13:06
@pan-kot pan-kot marked this pull request as draft January 28, 2026 13:14
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.17%. Comparing base (6a5486b) to head (a194f72).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4213      +/-   ##
==========================================
+ Coverage   97.16%   97.17%   +0.01%     
==========================================
  Files         879      882       +3     
  Lines       25780    25826      +46     
  Branches     9328     9331       +3     
==========================================
+ Hits        25049    25097      +48     
+ Misses        725      723       -2     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot pan-kot marked this pull request as ready for review January 28, 2026 14:04
@pan-kot pan-kot changed the title chore: Use size-limit v12 chore: Adjust plugin imports to only load metrics from the toolkit Jan 28, 2026
@pan-kot pan-kot enabled auto-merge January 28, 2026 14:13
"sass": "^1.89.2",
"sass-loader": "^12.3.0",
"size-limit": "^11.1.6",
"size-limit": "^12.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: This change is technically not needed, but let's keep it.

It was a dependency of @size-limit/esbuild-why which I used to create the graphs.

@pan-kot pan-kot requested a review from mxschll January 28, 2026 14:21
@pan-kot pan-kot added this pull request to the merge queue Jan 28, 2026
Merged via the queue into main with commit 17117bb Jan 28, 2026
51 checks passed
@pan-kot pan-kot deleted the size-limit-12 branch January 28, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants