This repository was archived by the owner on Aug 16, 2022. It is now read-only.
feat: FSx file-systems, aliases, DRAs#1273
Open
rocketbitz wants to merge 3 commits into
Open
Conversation
rocketbitz
requested review from
a team and
zagronitay
and removed request for
a team
rocketbitz
force-pushed
the
feature/fsx-file-systems
branch
from
0d00c6e to
739bb9b
Compare
rocketbitz
changed the title
rocketbitz
changed the title
yevgenypats
requested review from
irmatov and
roneli
and removed request for
zagronitay
Contributor
|
Hi @rocketbitz . Thank you for submitting this PR. Few comments:
You may find explanation to the missing steps on Feel free to comment on here or on our discord chat https://discord.gg/bAdBG5WU |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloudquery/cloudquery#1375
cloudquery/cloudquery#1376
cloudquery/cloudquery#1378
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)go run ./docs/docs.goand committing the changes 📃