Feat: Add remote_network_config configuration#258
Feat: Add remote_network_config configuration#258RoseSecurity merged 2 commits intocloudposse:mainfrom
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughAdds a new remote_network_config input and wiring across variables and examples, and implements corresponding dynamic configuration in the aws_eks_cluster resource to pass remote node and pod CIDR lists when provided. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
README.mdis excluded by!README.md
📒 Files selected for processing (5)
examples/complete/fixtures.us-east-2.tfvars(1 hunks)examples/complete/main.tf(1 hunks)examples/complete/variables.tf(1 hunks)main.tf(1 hunks)variables.tf(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
examples/complete/*.tf
⚙️ CodeRabbit configuration file
This is framework for testing and standards are very relaxed, plus certain things need to be certain ways for testing. Exclude from review unless you find misspelling or similar error in comments or serious errors in code.
Files:
examples/complete/main.tfexamples/complete/variables.tf
🔇 Additional comments (4)
variables.tf (1)
385-392: LGTM! Variable definition is well-structured.The variable correctly models the remote network configuration with required node CIDRs and optional pod CIDRs, aligning with the PR objective to support hybrid nodes and Cilium overlay mode.
examples/complete/fixtures.us-east-2.tfvars (1)
64-67: LGTM! Test fixture values are appropriate.The CIDR blocks provided are valid private IP ranges suitable for testing the remote network configuration feature.
examples/complete/variables.tf (1)
145-152: LGTM! Variable definition correctly mirrors root module.The variable definition in the example matches the root module's variable structure, allowing proper pass-through of the remote network configuration.
main.tf (1)
113-133: Verify AWS Terraform remote_network_config dynamic block usage.
- Confirm that
remote_node_networksandremote_pod_networkssupport exactly one block each (not multiple) and that wrapping the CIDR list in another list (for_each = […]) is required.- Confirm that the
cidrsargument accepts a list of CIDR strings rather than individual values.
Correct remote_network_config var reference Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
/terratest |
RoseSecurity
left a comment
There was a problem hiding this comment.
This is an awesome addition. Thanks for the contribution
|
These changes were released in v4.8.0. |
what
why
references