Skip to content

Telescopetest-io: Add Initial Filmstrip & Video tab#203

Open
Judyzc wants to merge 6 commits intocloudflare:mainfrom
Judyzc:filmstrip-video
Open

Telescopetest-io: Add Initial Filmstrip & Video tab#203
Judyzc wants to merge 6 commits intocloudflare:mainfrom
Judyzc:filmstrip-video

Conversation

@Judyzc
Copy link
Contributor

@Judyzc Judyzc commented Mar 16, 2026

Adds simple filmstrip & video tab to telescopetest.io/results. Closes #189

  • After talking with Sergey, the filmstrip should line up with the waterfall, NOT the video
  • Will think on how to link filmstrip to waterfall after waterfall component gets reworked/wrapped into telescopetest-io
  • Filmstrip timestamp end duration doesn't line up fully with video, as in the filmstrip usually goes on for much longer than the video. This could be some kind of issue with how filmstrip images are generated/numbered in telescope. This filmstrip also starts from 0s, which is different from telescope's --html option output which starts from 0.1s or 1s.
  • Changed [filename].ts to [...filename].ts to allow this endpoint to get one dir down nested resources, using Astro's dynamic API routing: https://docs.astro.build/en/guides/routing/#on-demand-dynamic-routes
    • Tested that this didn't break serving other resources
  • Checked on staging

@Judyzc Judyzc requested a review from a team March 16, 2026 21:26
@Judyzc Judyzc changed the title Telescopetest-io: Add Filmstrip & Video tab Telescopetest-io: Add Initial Filmstrip & Video tab Mar 16, 2026
MildMax
MildMax previously approved these changes Mar 17, 2026
Copy link

@MildMax MildMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left 1 comment about inline comments, but not a blocker.

Verified working order of the filmstrip & video tab in local env.

Copy link

@MildMax MildMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified working order of the filmstrip & video tab in local env; follow up issue created from prior review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test Results - Filmstrip & Video

2 participants