Remove force reconnect on each print#6
Open
RobertInAms wants to merge 2 commits intocleversolutions:masterfrom
Open
Remove force reconnect on each print#6RobertInAms wants to merge 2 commits intocleversolutions:masterfrom
RobertInAms wants to merge 2 commits intocleversolutions:masterfrom
Conversation
High print latency was caused by closing and opening the printer connection on each write. The reason given for this was that isConnected() can lie. In scenarios where the printer was power cycled, the reconnect did not actually reopen the connection with the printer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High print latency was caused by closing and opening the printer
connection on each write. The reason given for this was that
isConnected() can lie. In scenarios where the printer was power
cycled, the reconnect did not actually reopen the connection
with the printer.