🎪 Change the way platforms are imported ⚠️ DO NOT MERGE ⚠️#93
Open
stojanovic wants to merge 2 commits intomasterfrom
Open
🎪 Change the way platforms are imported ⚠️ DO NOT MERGE ⚠️#93stojanovic wants to merge 2 commits intomasterfrom
stojanovic wants to merge 2 commits intomasterfrom
Conversation
stojanovic
changed the title
stojanovic
changed the title
stojanovic
changed the title
simalexan
reviewed
May 28, 2017
| module.exports.SlackPlatform = SlackPlatform; | ||
| module.exports.TelegramPlatform = TelegramPlatform; | ||
| module.exports.TwilioPlatform = TwilioPlatform; | ||
| module.exports.ViberPlatform = ViberPlatform; |
Member
There was a problem hiding this comment.
this can be one object
module.exports = {
AlexaPlatform: AlexaPlatform,
...
};
| } | ||
| } | ||
|
|
||
| module.exports = ViberPlatform; |
Member
There was a problem hiding this comment.
if we compare the platform.js for all of these platforms we come to an identical structure, with the difference in just its parameters and enabled template()
~
maybe it can be a single object, with different params and a templates enabled or disabled
Member
Author
There was a problem hiding this comment.
It can, but the point is that this can be fully customized by any new plugin. We can probably create a base class and extend it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal: update the structure so we can import new platforms without adding them to the core and add plugin support.
To do: