This repository was archived by the owner on Sep 7, 2018. It is now read-only.
Work around fromJust #137
Open
Work around fromJust #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not only does this avoid fromJust, which lacks an unfolding in GHC 8.2, but the errors are slightly more informative.
Contributor
Author
|
So in principle this shouldn't be needed due to clash-lang/clash-compiler@e5faf05, which replaces |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in clash-lang/clash-compiler#274
Data.Maybe.fromJusthas no unfolding in GHC 8.2. Here I remove instances offromJustfromclash-prelude. This works around the issue and perhaps offers slightly better error messages at the expense of some verbosity. It's not clear to me that this is the right trade-off but it's been a useful temporary hack for me.