Draft
Conversation
Member
|
What do you think of making the tests similar to |
Member
Author
|
We can do that. But I would not remove the tests in checked-literals itself. This PR itself is still a WIP. It was quickly moving towards seeing if tests pass :) |
Member
|
Ok! I'll port it over. Yeah, I won't remove the tests in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces the brand new https://github.com/clash-lang/checked-literals plugin that makes sure literals in the code are proven to fit into the bounds of the type.
Still WIP because the package is not released but all instances are there.
Still TODO: