Improve deriveAutoReg constraint calculations#3111
Open
leonschoorl wants to merge 4 commits intomasterfrom
Open
Improve deriveAutoReg constraint calculations#3111leonschoorl wants to merge 4 commits intomasterfrom
leonschoorl wants to merge 4 commits intomasterfrom
Conversation
In addition to looking for constraints on AutoReg instances fields, we now also look for constraints on the NFDataX instance of the whole type.
This isn't strictly necessary. As GHC will handle the superflous constraints without problems. But it was cluttering up the documentation. The previous commit changed the AutoReg instance for a 2-tuple from: (AutoReg a, AutoReg b) => AutoReg (a, b) to: (AutoReg a, AutoReg b, NFDataX a, NFDataX b) => AutoReg (a, b) With this extra filtering step we're back to the original.
leonschoorl
force-pushed
the
fix-deriveAutoReg
branch
from
d6792a9 to
ff9d10b
Compare
leonschoorl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the constraint calculation issues in
deriveAutoRegseen in https://clash-lang.discourse.group/t/deriveautoreg-with-superclass-constraints/100In addition to looking for constraints on AutoReg instances fields,
deriveAutoRegnow also looks for constraints on the NFDataX instance of the whole type.Still TODO: