Add config declarations for harvest extension#575
Open
thorge wants to merge 2 commits intockan:masterfrom
Open
Add config declarations for harvest extension#575thorge wants to merge 2 commits intockan:masterfrom
thorge wants to merge 2 commits intockan:masterfrom
Conversation
hcvdwerf
approved these changes
Jan 30, 2026
Author
|
I changed the default value of Possible solutions include splitting the configuration variables per backend, or introducing more explicit conditional handling based on a shared default value. Should we address this as part of this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds config declarations for the CKAN Harvest extension, following the recommended
IConfigDeclarationpattern. All relevant configuration options are now explicitly declared, improving validation, normalization, and auto-documentation support.ckan.harvest.timeoutoption should ideally be declared withdeclare_int. However, the current implementation inharvest_jobs_run()inupdate.pychecks the value withif timeout:, and expectsNoneorFalseas default. Usingdeclare_intwould require adjustments to the timeout handling logic to safely support integer defaults.Fixes #564