dev/joomla#54 Delete admin/helpers/api.php - obsolete code#91
Open
webmaster-cses-org-uk wants to merge 1 commit intocivicrm:masterfrom
Open
dev/joomla#54 Delete admin/helpers/api.php - obsolete code#91webmaster-cses-org-uk wants to merge 1 commit intocivicrm:masterfrom
webmaster-cses-org-uk wants to merge 1 commit intocivicrm:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further work to resolve #54, specifically this list.
@seamuslee001 I am proposing that we delete this file as I cannot find any references to the
CivicrmHelperApiclass or either of its methods in the civicrm-joomla or civicrm-core codebase, and the purpose of this class is unclear? It has out-of-date code.The only other reference I can find to this file / class is in this blog post from 2011. Things have moved on since then! The documentation does not mention this class, and gives the necessary code to do the bootstrapping anyway.