Use the deleted file list to remove old files after installation

[chrisgaraffa]

Overview

Using the deleted files list from civicrm/civicrm-core#28653, the Joomla installers will now remove files from the filesystem that don't exist in the version being installed.

Before

The default Joomla installation process doesn't delete files on upgrade. This leads to outdated files that at best don't do anything and at worst can cause fatal errors.

After

The Joomla installation process now deletes files based on the deleted-files-list.json

[colemanw]

Cool. I think this will work with the files in the list but not the directories. Directory paths in deleted-files-list.json end in /*.

[chrisgaraffa]

Cool. I think this will work with the files in the list but not the directories. Directory paths in deleted-files-list.json end in /*.

Oh - missed that! I'll work something up with a DirectoryIterator and rmdir to catch /* at the end of the path and handle properly.

[thoni56]

Yes, this would be very valuable!

[elinw]

Hi ,
I was just going through this, and would it make more sense to have the installer delete the civicrm folder during the pre-flight and then when the new civicrm.zip is unzipped it would just have the new files?

[webmaster-cses-org-uk]

👍 to this, if we can get it over the line. Yes please!

The upgrade process is complicated enough as it is, without having to manually delete the civicrm directory every time!