Fix CRM-21347 Joomla auto-save of features fails

[twomice]

I think JHTML::_() needs separate arguments rather than an array of named parameters. This at least matches what I see in other Joomla code, and it works to solve the problem.

---

• CRM-21347: Joomla auto-save of features fails due to missing JavaScript file

[andrewpthompson]

@twomice I realise this is a pretty old PR! I haven't looked at the problem but the change doesn't look quite right to me.

I found a number of places in Joomla's core where an array is passed into JHtml::_(), for example:

• https://github.com/joomla/joomla-cms/blob/fe597ef10fe6d6f0841bebc8aeebaad72d7080f3/templates/beez3/component.php#L20
• https://github.com/joomla/joomla-cms/blob/fe597ef10fe6d6f0841bebc8aeebaad72d7080f3/administrator/components/com_contenthistory/helpers/html/textdiff.php#L46

The Joomla API docs show that the second and third paramaters should be arrays not bools. (The JHtml::_() class loader should pass the arguments to JHtml::script() if I understand correctly.)

[twomice]

Thanks, @andrewpthompson Joomla development is not my strong suit. If you care to make changes to the PR, that would be great.

But on another note, I wonder if the original issue is even still relevant. Before spending more time on this, I think one would want to see if the original issue (CRM-21347) is still happening in the latest versions of CiviCRM and Joomla.

[webmaster-cses-org-uk]

Hi all, do we know if this issue is still real or not? The proposed changes would conflict with #89 which is for J4/J5 compatibility.

We're on CiviCRM 6.6.1 (plus a fair few mods for J5, see open PRs) and Joomla 5.4.1 - when I change a permission it seems to save immediately and no JavaScript error? This is with the code as per #89.