[Rocket] add async-resets-as-sync arcilator flag#13
Merged
fabianschuiki merged 1 commit intocirct:mainfrom Jan 5, 2026
Merged
Conversation
fabianschuiki
approved these changes
Dec 18, 2025
Contributor
fabianschuiki
left a comment
fabianschuiki
left a comment
There was a problem hiding this comment.
LGTM! Do we need this for Boom and Snitch, too?
Contributor
Author
I don't think we have Snitch in the repo (on main at least)? As mentioned above I held off for BOOM since I don't think current Arcilator versions can digest the BOOM FIRRTL files we have in there anyway, I'll make a tracking issue for that |
Contributor
|
Ah yeah good point, that might be on the benchmark branch. We should probably merge that back into main at some point and just go with that 😁 |
Contributor
Author
|
Don't think I have push rights to this repo so if someone could hit merge for me that would be very appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modification to account for llvm/circt#9360, which introduces the
--async-resets-as-syncflag to Arcilator so that it requires users to explicitly specify they want their asynchronous resets to be interpreted as synchronous. This adds that flag to the Rocket Makefile - I didn't change it in the BOOM or Riscinator configs since AFAICT the versions we have of both are older versions of FIRRTL than CIRCT head supports anyway.