Lists: Update TIPCommon dependency#733
Conversation
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report🧩 IntegrationsPre-Build Stagelists
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug affecting custom list searches, particularly for items associated with multiple environments or wildcard environments. The fix is implemented by updating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Lists integration to version 14.0, primarily by upgrading the integration-testing and TIPCommon dependencies to version 2.3.7. The review feedback suggests two improvements: the release note description should be updated to focus on the functional bug fix for a Security Analyst persona, and new unit tests should be added to verify the bug fix, adhering to the style guide's requirement for all bug fixes.
b/502893537
a8d1401 to
d255d16
Compare
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report🧩 IntegrationsPre-Build Stagelists
|
1 similar comment
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report🧩 IntegrationsPre-Build Stagelists
|
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report🧩 IntegrationsPre-Build Stagemc_afee_active_response
websense
lastline
site24x7
observe_it
fire_eye_ex
illusive_networks
outpost24
f5_big_iq
mc_afee_atd
|
Title (Please follow the convention below)
[Buganizer ID: 502893537] Fix: Resolve Multi-Environment Search in Custom Lists
Description
Fixes a bug where searching for custom lists failed for items mapped to multiple environments or the wildcard
"[\"*\"]"environment. The previous logic used a restrictive strict equality (eq) check on theenvironmentsfield (stored as a JSON array string), which caused false negatives when searching for multi-environment items.Checklist:
Please ensure you have completed the following items before submitting your PR.
This helps us review your contribution faster and more efficiently.
General Checks:
Open-Source Specific Checks:
For Google Team Members and Reviewers Only: