Skip to content

feat: processings panel for experimental spectra operations#4214

Merged
tpoisseau merged 11 commits into
mainfrom
797-intermediate-work-for-e2e-checks
Jul 1, 2026
Merged

feat: processings panel for experimental spectra operations#4214
tpoisseau merged 11 commits into
mainfrom
797-intermediate-work-for-e2e-checks

Conversation

@tpoisseau

Copy link
Copy Markdown
Contributor

No description provided.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 22, 2026

Copy link
Copy Markdown

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5b7cb12
Status: ✅  Deploy successful!
Preview URL: https://963a1898.nmrium.pages.dev
Branch Preview URL: https://797-intermediate-work-for-e2.nmrium.pages.dev

View logs

put processings in a local state to apply basic implementation on it.

* delete all processings
* delete a processings
* open section on edit button click
* reorder processings
@tpoisseau tpoisseau changed the title wip: processings panel for spectra operations feat: processings panel for experimental spectra operations Jun 30, 2026
@tpoisseau

tpoisseau commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

For some reasons (I don't know why...) peak picking generate less peaks than before.

I don't know what to do.

On main branch:
CleanShot 2026-07-01 at 11 38 11@2x

On this branch:
CleanShot 2026-07-01 at 11 38 34@2x

I consider peaks much more pertinent in this branch than before.
Reminder: I did not touch anything related to peaks on this branch. but core had been updated.

I suggest reducing the expected number of peaks to 23 (the number of peaks currently generated with this setup) in the test file.
Do you agree with this plan @targos ?

@targos

targos commented Jul 1, 2026

Copy link
Copy Markdown
Member

This includes an update of nmr-processing, which contains https://github.com/zakodium/nmrium/pull/807
This seems like an expected improvement from that PR.

@tpoisseau tpoisseau marked this pull request as ready for review July 1, 2026 10:03
@tpoisseau tpoisseau merged commit cd38501 into main Jul 1, 2026
12 checks passed
@tpoisseau tpoisseau deleted the 797-intermediate-work-for-e2e-checks branch July 1, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants