feat: Vertical Cell Merging In Table Columns#492
Open
eloubens wants to merge 10 commits intocharmbracelet:masterfrom
Open
feat: Vertical Cell Merging In Table Columns#492eloubens wants to merge 10 commits intocharmbracelet:masterfrom
eloubens wants to merge 10 commits intocharmbracelet:masterfrom
Conversation
Member
|
Hi! Thanks for the contribution. This is an impressive implementation, however we're unlikely to merge it in the short term because of the upcoming v2 release (maintained on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Merge adjacent vertical cells in the columns specified by a new []int field in the Table struct called borderMergeColumns.
Borders in between adjacent vertical cells containing identical data in these columns would be removed, where only the topmost cell's contents would remain with all other cell contents being hidden.
Example
Merge the first and last column

Details
This functionality would only work if both borderColumn and borderRow are set to true. For example, if a user wanted to merge vertical cells in columns 0, 2, 3, when creating the table, the user would need to add table.New().borderColumn(true).borderRow(true).BorderMergeColumns(0,2,3)
All other functionality would remain the same : borderColumn(true).borderRow(true) would just draw all borders, borderColumn(true).borderRow(false) would only draw the column borders... etc
Testing
All unit tests are in
lipgloss/table/table_borders_test.go