Conversation
andreynering
left a comment
andreynering
left a comment
There was a problem hiding this comment.
This looks very good. Thank you!
There are a few things we can adjust before merging. I would consider pushing, but I don't have access to your branch.
- Remove debug code (mentioned below).
- Linting needs to be fixed. (All very simple. Just run
task lintorgolangci-lint runto see). - You might want to add a short README to
providers/kronk/README.mdexplaining what Kronk is and a couple links maybe.
Other than that, there are integrations test to write (they are on providertests/), but that's something we can do ourselves after merging.
I certainly want @kujtimiihoxha's review here, as he's more experienced on the internals of Fantasy.
providers/kronk/language_model.go
Outdated
| "github.com/google/uuid" | ||
| ) | ||
|
|
||
| var debugStream = os.Getenv("FANTASY_DEBUG_STREAM") != "" |
There was a problem hiding this comment.
We'll want to remove this and the blocks that check for it.
|
I have added you (@andreynering ) and @kujtimiihoxha to the repo. I don't use I will look at those three items today. Thanks! |
|
DONE: Remove debug code (mentioned below). |
|
@andreynering I updated the code to the latest version of Kronk and made sure the examples are working. Sorry for letting this go so long :( |
|
@ardan-bkennedy No problem at all! We're also busy at Charm, but this is in my TODO list and I'll come back once possible. 🙂 |
|
No worries and no rush. I just snuck in 1.16.3 |
|
Upgraded to v1.17.6 of Kronk |
|
Any updates on this? 👁️ |
|
Hopefully I'll fine the time to review this soon 🙏 |
3 participants
CONTRIBUTING.md.After the ArdanLabs live coding show, Carlos, Andrey, and I was able to produce this new provider from Kronk. I've performed code cleanup, made sure tool calling is working, and created new examples.