Open
Conversation
evamillan
force-pushed
the
integration-core
branch
from
5bcd5dc to
e569410
Compare
evamillan
force-pushed
the
integration-core
branch
from
e569410 to
3da3ac7
Compare
Moves the Apollo provider to a configurable `setupApolloProvider` function. Signed-off-by: Eva Millán <evamillan@bitergia.com>
Splits the Vuex workspace store into a reusable module. Signed-off-by: Eva Millán <evamillan@bitergia.com>
Creates a Vue plugin in the `/package` directory that includes the Dashboard, Individual and Organization views. Signed-off-by: Eva Millán <evamillan@bitergia.com>
Changes the CSS and some Vuetify components to make them look properly when embedded in another project. Signed-off-by: Eva Millán <evamillan@bitergia.com>
Builds and attachs the UI package to the release. Signed-off-by: Eva Millán <evamillan@bitergia.com>
sduenas
force-pushed
the
integration-core
branch
from
3da3ac7 to
264cd3d
Compare
sduenas
requested changes
Jan 20, 2026
Member
sduenas
left a comment
sduenas
left a comment
There was a problem hiding this comment.
Please check my comments. I found a problem while building the app.
Comment on lines
+38
to
+43
| yarn pack --filename sortinghat-ui.tgz | ||
| - name: Upload UI artifact | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: sortinghat-ui | ||
| path: ./ui/package/sortinghat-ui.tgz |
Member
There was a problem hiding this comment.
I think we should include the version in the name of the file. Follow the style of js packages.
| current project. Use `yarn build --watch` to rebuild when the code changes. | ||
|
|
||
| ``` | ||
| cd sortinghat/ui/package |
Member
There was a problem hiding this comment.
Suggested change
| cd sortinghat/ui/package | |
| cd ui/package |
|
|
||
| ``` | ||
| cd sortinghat/ui/package | ||
| yarn build |
Member
There was a problem hiding this comment.
Should we add the yarn install first (to update dependencies)?
Member
There was a problem hiding this comment.
I found this problem while building:
$ yarn build
You are using Node.js 20.11.1. Vite requires Node.js version 20.19+ or 22.12+. Please upgrade your Node.js version.
vite v7.1.10 building for production...
✓ 7 modules transformed.
✗ Build failed in 198ms
error during build:
[vite:vue] crypto.hash is not a function
file: /home/sduenas/devel/grimoirelab/sortinghat/ui/src/views/Dashboard.vue
at getHash (file:///home/sduenas/devel/grimoirelab/sortinghat/ui/package/node_modules/@vitejs/plugin-vue/dist/index.js:140:16)
at createDescriptor (file:///home/sduenas/devel/grimoirelab/sortinghat/ui/package/node_modules/@vitejs/plugin-vue/dist/index.js:89:23)
at transformMain (file:///home/sduenas/devel/grimoirelab/sortinghat/ui/package/node_modules/@vitejs/plugin-vue/dist/index.js:1633:33)
at Object.handler (file:///home/sduenas/devel/grimoirelab/sortinghat/ui/package/node_modules/@vitejs/plugin-vue/dist/index.js:2045:27)
at Object.handler (file:///home/sduenas/devel/grimoirelab/sortinghat/ui/package/node_modules/vite/dist/node/chunks/dep-B0GuR2De.js:33959:13)
at file:///home/sduenas/devel/grimoirelab/sortinghat/ui/package/node_modules/rollup/dist/es/shared/node-entry.js:22426:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to integrate SortingHat's user interface into grimoirelab-core, this PR creates a package with the main views (dashboard, individuals and organizations) that can be installed in a separate Vue project. The package is generated and included in the release assets (a test release with the installable package can be found here).