Add secrets manager integration for credential retrieval#887
Closed
alberefe wants to merge 1 commit intochaoss:mainfrom
Closed
Add secrets manager integration for credential retrieval#887alberefe wants to merge 1 commit intochaoss:mainfrom
alberefe wants to merge 1 commit intochaoss:mainfrom
Conversation
0a86462 to
66a1791
Compare
sduenas
reviewed
Feb 27, 2026
Member
sduenas
left a comment
There was a problem hiding this comment.
This looks promising. My main concern is that this only works using perceval from the command line and not as library. chronicler and mordred are two examples of perceval used as a library.
I think it would be better if perceval handles the access to the credentials on the backend and not in the backend command. What do you think?
Signed-off-by: Alberto Ferrer Sánchez <alberefe@gmail.com>
66a1791 to
1a67e29
Compare
Author
|
Closed it cause I'm making changes to adapt to what you said, also including changes to toolkit to modularize the functions and make it so the changes to perceval and others are minimal and everything stays inside toolkit as much as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BackendCommand._pre_init()and injected intoparsed_args(user, password, api_token, email, etc.), which backends already consume via HTTP headers/session auth--secrets-manager,--item-name,--token-field, etc.) across 14 backends: bugzilla, bugzillarest, confluence, discourse, gerrit, git, github, gitlab, gitter, googlehits, groupsio, jenkins, rocketchat,stackexchange
hashicorp-managerdependency group (hvac >= 2.3.0) in pyproject.toml