Refactor Backend.fetch to centralize logic#848
Open
vchrombie wants to merge 1 commit intochaoss:mainfrom
Open
Conversation
vchrombie
force-pushed
the
527-simply-fetch-and-fetch_items
branch
6 times, most recently
from
f9e99f1 to
529c9ab
Compare
Member
|
I saw two weeks ago some code to change this problem but I don't see it now. Any issues with it? Is there any way I can help? |
vchrombie
force-pushed
the
527-simply-fetch-and-fetch_items
branch
from
529c9ab to
921f269
Compare
Member
Author
|
I am taking a stab at this again, will fix the linting issues and remove the changes to tests. |
vchrombie
force-pushed
the
527-simply-fetch-and-fetch_items
branch
from
921f269 to
5c5025e
Compare
vchrombie
force-pushed
the
527-simply-fetch-and-fetch_items
branch
from
5c5025e to
fbbab39
Compare
Refactor `Backend.fetch` to support `**kwargs` and delegate directly to `fetch_items()`. This removes the need for subclasses to override `fetch()` solely for parameter passing. Updated 30+ backends to handle default parameters (like `from_date`, `offset`) within `fetch_items()` instead of `fetch()`. Signed-off-by: Venu Vardhan Reddy Tekula <venuvrtekula@gmail.com>
vchrombie
force-pushed
the
527-simply-fetch-and-fetch_items
branch
from
fbbab39 to
7c0fa18
Compare
vchrombie
changed the title
fetch() and fetch_items() in the backendsBackend.fetch to centralize logic
Member
Author
|
@sduenas, could you please take a chance to review this approach? What do you think, let me know if you have any suggestions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #527
I trying an attempt to solve this issue. I picked the Gitter backend to get started and see get some feedback on the changes. I will be working on rest of the backends one by one. I am sure this is going to be a huge PR, so I will take some time and add a backend each time allowing time for reviewing.
Let me know if you have any suggestions.