Gitlab Client: Parse owner and repository in a url safe way#698
Gitlab Client: Parse owner and repository in a url safe way#698StingRayZA wants to merge 1 commit intochaoss:mainfrom
Conversation
StingRayZA
force-pushed
the
gitlab-safe-urls
branch
from
a002b6e to
f3845a1
Compare
|
Thanks for the PR. I need some time to review it. I'll do it this weekend. |
|
Hi 👋 |
|
@StingRayZA I cannot merge the PR right now because it will break other parts of the tool chain. They expect the URLs as they are now. Would you mind to rebase your PR to master and improve the commit message. It is described in the contributing rules. I won't merge it but I will set it as a hacktober contribution. |
|
Sure, no problem I'll rebase and reformat the commit message. |
This allows us to retain the '/' separation of URL pieces in any gitlab urls that have been stored in the object. This change also lays the groundwork for a fix in the -elk repository to allow multiple nested gitlab group layers in gitlab URLs. See also: chaoss/grimoirelab-elk#946 Signed-off-by: Raimund Hook <raimund.hook@exfo.com>
StingRayZA
force-pushed
the
gitlab-safe-urls
branch
from
f3845a1 to
5fa96f1
Compare
|
@sduenas Rebased on master with a reformatted message. |
sduenas
left a comment
sduenas
left a comment
There was a problem hiding this comment.
LGTM
As I said, I'll merge it when we fix the related problems in ELK.
2 participants
Instead of stitching the 'owner' and 'repository' together with a
%2F- rather join them with a/and let python make them conformant.This way, if we have any
/characters embedded in either value, they too will be correctly translated