[launchpad] Add missing package parameter in launchpad#660
Merged
valeriocos merged 1 commit intochaoss:masterfrom May 2, 2020
Merged
[launchpad] Add missing package parameter in launchpad#660valeriocos merged 1 commit intochaoss:masterfrom
package parameter in launchpad#660valeriocos merged 1 commit intochaoss:masterfrom
Conversation
valeriocos
reviewed
May 2, 2020
Member
valeriocos
left a comment
valeriocos
left a comment
There was a problem hiding this comment.
@imnitishng thank you for the PR! It looks perfect, but I made a mistake saying to increase the version to 0.9.0, it should be 0.8.1. Sorry about that!
Could add to the commit message a last sentence saying that the backend version is now 0.8.1?
Thanks!
This commit adds missing parameter `package` in the launchpad backend. Launchpad can now work on both, distributions and distribution packages. Tests have also been added. The backend version is now 0.8.1. Signed-off-by: Nitish Gupta <imnitish.ng@gmail.com>
imnitishng
force-pushed
the
launchpad_params
branch
from
f13f504 to
317e7f8
Compare
Contributor
Author
|
Done! |
valeriocos
approved these changes
May 2, 2020
Member
valeriocos
left a comment
valeriocos
left a comment
There was a problem hiding this comment.
LGTM thank you @imnitishng
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing parameter
packagein thelaunchpad backend. Launchpad can now work on both,
distributions and distribution packages.
Tests have also been added.
Based on the discussion here chaoss/grimoirelab-elk#851 (comment)
Signed-off-by: Nitish Gupta imnitish.ng@gmail.com