[git] Remove unnecessary quotes from branch names in enrichment#1224
Open
3idey wants to merge 1 commit intochaoss:mainfrom
Open
[git] Remove unnecessary quotes from branch names in enrichment#12243idey wants to merge 1 commit intochaoss:mainfrom
3idey wants to merge 1 commit intochaoss:mainfrom
Conversation
Branch names in the branches field were being stored with surrounding single quotes (e.g., 'main', 'develop') instead of plain branch names. This fix removes the extra quotes by changing the Painless script parameter from "'%s'" to "%s" in __process_commits_in_branch(). Git already rejects branch names with spaces or special characters, and the value is safely passed as a script parameter, so no escaping or quoting is necessary. Fixes chaoss#1176 Signed-off-by: 3idey <elaidya225@gmail.com>
3idey
force-pushed
the
fix-quoted-branch-names
branch
from
a31e33c to
561758f
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes unnecessary single quotes that were being added to branch names when storing them in the branches field during Git repository enrichment. The fix changes the Painless script parameter from "'%s'" to "%s" so branch names are stored as plain strings (e.g., main, develop) instead of quoted strings (e.g., 'main', 'develop').
Changes:
- Removed single quote wrapping from branch parameter in
__process_commits_in_branch()method
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch names in the branches field were being stored with surrounding single quotes (e.g., 'main', 'develop') instead of plain branch names.
This fix removes the extra quotes by changing the Painless script parameter from "'%s'" to "%s" in __process_commits_in_branch().
Git already rejects branch names with spaces or special characters, and the value is safely passed as a script parameter, so no escaping or quoting is necessary.
Fixes #1176