Add actual SQLAlchemy Sequence objects so db can be initialized with SQLAlchemy#3471
Open
Add actual SQLAlchemy Sequence objects so db can be initialized with SQLAlchemy#3471
Conversation
MoralCode
force-pushed
the
ntdn/sequences
branch
2 times, most recently
from
bc44e60 to
f8b4e37
Compare
MoralCode
added
the
high priority
Member
|
@MoralCode : Flag this one for me when you think its ready. |
MoralCode
changed the title
…calls Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…calls Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
How this ever got like this is beyond me Signed-off-by: Adrian Edwards <adredwar@redhat.com>
MoralCode
force-pushed
the
ntdn/sequences
branch
from
5da076e to
b83b76b
Compare
ABrain7710
previously approved these changes
Feb 18, 2026
Signed-off-by: Adrian Edwards <17362949+MoralCode@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This was initially discovered while trying to fix the test fixtures to get the database-dependent tests back up and running. It was something that prevented databases created purely with SQLAlchemy (rather than replaying every migration) from successfully coming up.
Converting these values to use SQLAlchemy allows SQLAlchemy to emit the correct SQL to generate these sequences in the database again.
This was originally part of #3435 but is being factored out to keep the diff of that change small.
This change incorporates feedback from @shlokgilda in the above-mentioned PR that says that SQLAlchemy sequences don't inherit the table's schema automatically
Notes for Reviewers
Signed commits