Skip to content
This repository was archived by the owner on Mar 15, 2025. It is now read-only.

Update styles_theme.xml#212

Open
RickyTUM wants to merge 3 commits intocgeo:masterfrom
RickyTUM:master
Open

Update styles_theme.xml#212
RickyTUM wants to merge 3 commits intocgeo:masterfrom
RickyTUM:master

Conversation

@RickyTUM
Copy link

@RickyTUM RickyTUM commented Sep 1, 2020

When I make the following change to the file:
src/main/res/values/styles_theme.xml
the menu looks good.

Tested on Android 5 to 9

@RickyTUM
Update styles_theme.xml
0ca6977 
When I make the following change to the file:
src/main/res/values/styles_theme.xml
the menu looks good on Android 7 and 9.
@cgeo-ci-bot
Copy link
Collaborator

cgeo-ci-bot commented Sep 1, 2020

Can one of the admins verify this patch?

@Lineflyer
Copy link
Member

Lineflyer commented Sep 1, 2020

Hello @RickyTUM and thanks for your contribution.
Is this related to any issue?
Maybe you can describe the reason of your proposed change.

@RickyTUM
Copy link
Author

RickyTUM commented Sep 1, 2020

Yeah, it fits:
#66

After that I didn't have the problem on Android 9 anymore.

In the emulator from Android 5 to 10 also not

@bekuno
Copy link
Member

bekuno commented Sep 1, 2020

ok to test

@bekuno
Copy link
Member

bekuno commented Sep 1, 2020

I made a short test with the generated apk.
The initial problem is is still present on Android 9 (Samsung Note 8).

@bekuno
Copy link
Member

bekuno commented Sep 2, 2020

@Lineflyer Can you test the apk?

@bekuno bekuno linked an issue Sep 21, 2020 that may be closed by this pull request
Map menu text color is black instead of white #66
Open
RickyTUM
RickyTUM commented Oct 31, 2020
View reviewed changes
Copy link
Author

@RickyTUM RickyTUM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone please test this on Samsung devices?

The menu is ok on:
Nexus 4, Android 7
Nexus 5x, Android 8
Nokia 8, Android 9
Pixel 5, Android 11

@bekuno
Copy link
Member

bekuno commented Nov 3, 2020

Sorry, bad news.
It is unchanged and therefore not ok on Samsung Note8, Android 9.
(It is ok on Samsung S6, Android 7)

@Lineflyer Lineflyer added the Do not merge / WIP Not for merging and/or work still in progress label Dec 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@RickyTUM RickyTUM

Labels

Do not merge / WIP Not for merging and/or work still in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Map menu text color is black instead of white

4 participants

@RickyTUM @cgeo-ci-bot @Lineflyer @bekuno