Merged
Conversation
Removed the Dict39 dependency on test_bot_library_mode.py
sebix
requested changes
Aug 20, 2025
Member
sebix
left a comment
There was a problem hiding this comment.
The codestyle check fails:
intelmq/lib/bot.py:1530:26: E127 continuation line over-indented for visual indent
intelmq/lib/datatypes.py:140:1: W391 blank line at end of file
While you are at it, could you please add this snippet to the CHANGELOG.md in section Core?
- `intelmq.lib.datatypes`: Remove unneeded Dict39 alias (PR#2639 by Nakul Rajpal, fixes #2635)
Contributor
Author
|
@sebix added said changes. |
sebix
requested changes
Aug 21, 2025
Member
sebix
left a comment
There was a problem hiding this comment.
pycodestyle intelmq/{bots,lib,bin}
intelmq/lib/bot.py:1533:64: W292 no newline at end of file
intelmq/lib/datatypes.py:140:1: W391 blank line at end of file
Contributor
Author
|
@sebix Sorry for the minute changes. Everything should be ready now. |
sebix
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2635
Summary
Removes the
Dict39alias across IntelMQ. Since IntelMQ now requires Python ≥3.9, the alias is no longer necessary.Details
Dict39 = dictfromintelmq/lib/datatypes.pyDict39({...})with standard{...}in:intelmq/lib/bot.pyintelmq/tests/lib/test_bot_library_mode.pyDict39imports.