problem with allowed days detection in ceph-gentle-reweight script

[casparsmit]

There's a bug in the "in_timeframe" routine in the ceph-gentle-reweight script.

If the current_day is not in allowed_days but the current_time does fall between start_time and end_time it still allows the script to run. It shouldn't because the current_day is not allowed.

[johnavp1989]

This is the behavior I intended. allowed_days allows tells the script to reweight non-stop on those days regardless of whether there is a time range specified. My use case was that I wanted to allow reweighting only at nights and on weekends. See #7

[casparsmit]

Thank you for clarifying John!

I have the exact opposite use case, only run on weekdays (monday-friday) from 9:00 am until 16:00 pm and DON'T run in the weekend.

Is that possible with the current implementation? I don't see how.

Kind regards,
Caspar