Simplify Include Directives Hash#1311
Open
tommy-russoniello wants to merge 1 commit intocerebris:masterfrom
Open
Simplify Include Directives Hash#1311tommy-russoniello wants to merge 1 commit intocerebris:masterfrom
tommy-russoniello wants to merge 1 commit intocerebris:masterfrom
Conversation
| "related" => "http://test.host/api/things/40/things" | ||
| } | ||
| }, | ||
| "data" => [] |
Collaborator
There was a problem hiding this comment.
@lgebhardt I would like you to confirm something about this change.
@tommy-russoniello asked me why this would have changed but L4389 has another resource that did not change to include data. My explanation for this is that this resource is not a leaf in the things.things.things include, but the other one is, so we did the work of looking up the related things for this one, but not the other.
scottgonzalez
approved these changes
Feb 25, 2020
lgebhardt
approved these changes
Mar 15, 2020
Member
lgebhardt
left a comment
There was a problem hiding this comment.
@tommy-russoniello Thanks for cleaning this up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies include directives hashes by removing the
include_relatedsubhash under each entity. This indirection exists because of anincludekey that used to be in each hash, but was removed. Since there are never any other keys in the hashes, theinclude_relatedsubhashes are no longer necessary.In doing this, I also found (and fixed) a small bug where the processor tries to use an include directives hash as a key for its own subhash instead of the symbol
:include_related.All Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: