rbd: use StorageClass image features for temp clones and snapshots (backport #6205)#6217
Open
mergify[bot] wants to merge 2 commits intorelease-v3.16from
Open
rbd: use StorageClass image features for temp clones and snapshots (backport #6205)#6217mergify[bot] wants to merge 2 commits intorelease-v3.16from
mergify[bot] wants to merge 2 commits intorelease-v3.16from
Conversation
Contributor
Author
|
Cherry-pick of 0e81334 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
|
conflicts in e2e because of By() changed to It(). @Rakshith-R , do you think we might need to backport #6136? |
Member
Please just use |
iPraveenParihar
force-pushed
the
mergify/bp/release-v3.16/pr-6205
branch
from
97a48d0 to
64ce679
Compare
nixpanic
approved these changes
Apr 2, 2026
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.33 |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
mergify
bot
added
the
ci/in-progress/e2e
Collaborator
|
/test ci/centos/upgrade-tests-cephfs |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.33 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
Collaborator
|
/test ci/centos/upgrade-tests-rbd |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.33 |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.34 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.32 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.34 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.34 |
Member
|
@iPraveenParihar , feel free to approve this :) |
iPraveenParihar
approved these changes
Apr 3, 2026
Contributor
Author
Merge Queue Status
Required conditions to merge
Required conditions to stay in the queue
|
Previously, temporary clone images (-temp) and snapshot backing images had their features hard-coded to only layering and deep-flatten. Inherit the image features from the parent volume (configured via StorageClass imageFeatures) while ensuring layering and deep-flatten are always enabled, as they are required for the flatten operation. Signed-off-by: Praveen M <m.praveen@ibm.com> (cherry picked from commit 28daf2e)
Add an e2e test that verifies the intermediate RBD images created during snapshot and clone operations inherit StorageClass image features. Specifically validates: - csi-snap-* (snapshot backing image) inherits features from parent - csi-vol-*-temp (temp clone image) inherits features from parent Signed-off-by: Praveen M <m.praveen@ibm.com> (cherry picked from commit 0e81334) # Conflicts: # e2e/rbd.go # e2e/rbd_helper.go
ceph-csi-bot
force-pushed
the
mergify/bp/release-v3.16/pr-6205
branch
from
64ce679 to
27f9c96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Fixes: #4936
Checklist:
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
This is an automatic backport of pull request #6205 done by [Mergify](https://mergify.com).