Skip to content

fix(helm): fix invalid YAML syntax and nil pointer in values.yaml (backport #5990)#6216

Merged
mergify[bot] merged 1 commit intorelease-v3.16from
mergify/bp/release-v3.16/pr-5990
Apr 2, 2026
Merged

fix(helm): fix invalid YAML syntax and nil pointer in values.yaml (backport #5990)#6216
mergify[bot] merged 1 commit intorelease-v3.16from
mergify/bp/release-v3.16/pr-5990

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Apr 1, 2026

The template check for domainLabels evaluates empty arrays as truthy,
causing an invalid --domainlabels= flag to be generated. Fix by
checking that the array is both defined and non-empty before generating
the flag.

Keep domainLabels: [] in values.yaml for better user experience -
users can uncomment example values without needing to add the array
syntax back."

This is an automatic backport of pull request #5990 done by Mergify.

@KeshavSoni2511 @mergify
helm: fix domainLabels empty array handling in template
b4c23f3 
The template check for domainLabels evaluates empty arrays as truthy,
causing an invalid --domainlabels= flag to be generated. Fix by
checking that the array is both defined and non-empty before generating
the flag.

Keep domainLabels: [] in values.yaml for better user experience -
users can uncomment example values without needing to add the array
syntax back.

Signed-off-by: KeshavSoni2511 <keshavsoni2511@gmail.com>
(cherry picked from commit 057d55b)
@mergify mergify bot added ci/in-progress/e2e This label acts like a guard and prevents Mergify from adding the `ok-to-test` label again. ok-to-test Label to trigger E2E tests component/deployment Helm chart, kubernetes templates and configuration Issues/PRs bug Something isn't working labels Apr 1, 2026
@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 1, 2026

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 1, 2026

/test ci/centos/k8s-e2e-external-storage/1.32

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 1, 2026

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 1, 2026

/test ci/centos/mini-e2e-helm/k8s-1.32

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 1, 2026

/test ci/centos/k8s-e2e-external-storage/1.33

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 1, 2026

/test ci/centos/k8s-e2e-external-storage/1.34

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 1, 2026

/test ci/centos/mini-e2e/k8s-1.32

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 1, 2026

/test ci/centos/mini-e2e-helm/k8s-1.33

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 1, 2026

/test ci/centos/mini-e2e-helm/k8s-1.34

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 1, 2026

/test ci/centos/mini-e2e/k8s-1.33

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 1, 2026

/test ci/centos/mini-e2e/k8s-1.34

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Apr 1, 2026
@nixpanic nixpanic requested a review from a team April 1, 2026 08:49
@iPraveenParihar iPraveenParihar added the ok-to-test Label to trigger E2E tests label Apr 2, 2026
@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 2, 2026

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 2, 2026

/test ci/centos/k8s-e2e-external-storage/1.34

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 2, 2026

/test ci/centos/k8s-e2e-external-storage/1.32

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 2, 2026

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 2, 2026

/test ci/centos/mini-e2e-helm/k8s-1.34

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 2, 2026

/test ci/centos/mini-e2e-helm/k8s-1.32

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 2, 2026

/test ci/centos/mini-e2e/k8s-1.34

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 2, 2026

/test ci/centos/k8s-e2e-external-storage/1.33

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 2, 2026

/test ci/centos/mini-e2e/k8s-1.32

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 2, 2026

/test ci/centos/mini-e2e-helm/k8s-1.33

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Apr 2, 2026

/test ci/centos/mini-e2e/k8s-1.33

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Apr 2, 2026
@nixpanic nixpanic added the ci/skip/multi-arch-build skip building on multiple architectures label Apr 2, 2026
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Apr 2, 2026 •
edited
Loading

Merge Queue Status

  • ✅ Entered queue — 2026-04-02 08:52 UTC · Rule: default
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-04-02 08:52 UTC · at b4c23f3d95ddd04837a81c861995d35d9296e0f7

This pull request spent 10 seconds in the queue, including 1 second running CI.

Required conditions to merge

@mergify mergify bot merged commit 29fc2f4 into release-v3.16 Apr 2, 2026
61 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nixpanic nixpanic nixpanic approved these changes

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

Assignees

No one assigned

Labels

bug Something isn't working ci/in-progress/e2e This label acts like a guard and prevents Mergify from adding the `ok-to-test` label again. ci/skip/multi-arch-build skip building on multiple architectures component/deployment Helm chart, kubernetes templates and configuration Issues/PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ceph-csi-bot @nixpanic @iPraveenParihar @KeshavSoni2511