build: add go-lint-fix Makefile target#6208
Merged
mergify[bot] merged 1 commit intoceph:develfrom Mar 30, 2026
Merged
Conversation
mergify
bot
added
component/build
There was a problem hiding this comment.
Pull request overview
Adds a convenient “auto-fix” lint workflow for Go by introducing a new Makefile target and allowing scripts/lint-go.sh to forward extra CLI flags to golangci-lint.
Changes:
- Add
go-lint-fixMakefile target that runsgolangci-lintwith--fix - Update
scripts/lint-go.shto forward additional arguments ("$@") togolangci-lint
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
scripts/lint-go.sh |
Forwards extra CLI args to golangci-lint run to support --fix and other flags. |
Makefile |
Adds go-lint-fix target wired to ./scripts/lint-go.sh --fix. |
3 tasks
nixpanic
added
ci/skip/e2e
kaovilai
force-pushed
the
add-go-lint-fix-target
branch
2 times, most recently
from
b9d0246 to
21a8fa6
Compare
nixpanic
requested changes
Mar 30, 2026
Member
nixpanic
left a comment
nixpanic
left a comment
There was a problem hiding this comment.
the new go-lint-fix make target should be marked as .PHONY.
Contributor
Author
|
@nixpanic see line 95 |
nixpanic
approved these changes
Mar 30, 2026
iPraveenParihar
approved these changes
Mar 30, 2026
Contributor
|
@Mergifyio rebase |
Add a go-lint-fix target that passes --fix to golangci-lint via lint-go.sh, enabling automatic fixing of lint issues. The lint-go.sh script now forwards any additional arguments to golangci-lint. Usage: make containerized-test TARGET=go-lint-fix Assisted-by: Claude (Anthropic) <noreply@anthropic.com> Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
ceph-csi-bot
force-pushed
the
add-go-lint-fix-target
branch
from
21a8fa6 to
32efe52
Compare
Contributor
✅ Branch has been successfully rebased |
Contributor
Merge Queue Status
This pull request spent 7 minutes 13 seconds in the queue, including 7 minutes running CI. Required conditions to merge
|
Contributor
|
@Mergifyio queue |
Contributor
☑️ This pull request is already queued |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go-lint-fixMakefile target that passes--fixto golangci-lintscripts/lint-go.shto forward additional arguments ("$@") to golangci-lintUsage:
make containerized-test TARGET=go-lint-fixTest plan
make containerized-test TARGET=go-lintstill works as beforemake containerized-test TARGET=go-lint-fixauto-fixes lint issuesNote
Responses generated with Claude
Generated with Claude Code
via Happy