rbd: use StorageClass image features for temp clones and snapshots (backport #6205)#6217
rbd: use StorageClass image features for temp clones and snapshots (backport #6205)#6217mergify[bot] wants to merge 2 commits intorelease-v3.16from
Conversation
|
Cherry-pick of 0e81334 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
conflicts in e2e because of By() changed to It(). @Rakshith-R , do you think we might need to backport #6136? |
Please just use |
97a48d0 to
64ce679
Compare
|
/test ci/centos/k8s-e2e-external-storage/1.33 |
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e-helm/k8s-1.33 |
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.33 |
|
/test ci/centos/k8s-e2e-external-storage/1.34 |
|
/test ci/centos/mini-e2e/k8s-1.32 |
|
/test ci/centos/mini-e2e-helm/k8s-1.34 |
|
/test ci/centos/mini-e2e/k8s-1.34 |
|
@iPraveenParihar , feel free to approve this :) |
Merge Queue Status
This pull request spent 6 hours 6 minutes 30 seconds in the queue, with no time running CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to failing checks HintYou may have to fix your CI before adding the pull request to the queue again. |
Previously, temporary clone images (-temp) and snapshot backing images had their features hard-coded to only layering and deep-flatten. Inherit the image features from the parent volume (configured via StorageClass imageFeatures) while ensuring layering and deep-flatten are always enabled, as they are required for the flatten operation. Signed-off-by: Praveen M <m.praveen@ibm.com> (cherry picked from commit 28daf2e)
Add an e2e test that verifies the intermediate RBD images created during snapshot and clone operations inherit StorageClass image features. Specifically validates: - csi-snap-* (snapshot backing image) inherits features from parent - csi-vol-*-temp (temp clone image) inherits features from parent Signed-off-by: Praveen M <m.praveen@ibm.com> (cherry picked from commit 0e81334) # Conflicts: # e2e/rbd.go # e2e/rbd_helper.go
64ce679 to
27f9c96
Compare
Describe what this PR does
Fixes: #4936
Checklist:
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
This is an automatic backport of pull request #6205 done by [Mergify](https://mergify.com).