feat(#4): ticket intake form — US-012

[smarcetic]

Summary

Implements US-012: as a field technician, I want a web-based intake form so I can submit support requests without cURL or API tooling.

Closes #4

---

What's in this PR

Layer	File	Status
Architecture	docs/adr/ADR-0005-intake-form-templating.md	✅ committed
Tests	tests/test_intake_form.py	✅ 10 xfail + 1 regression passing
Implementation	src/triage_assistant/api/templates/intake.html	❌ needs implementation
Implementation	src/triage_assistant/api/main.py (GET /)	❌ needs implementation
Implementation	pyproject.toml (jinja2 dep)	❌ needs implementation

---

TDD Status

All 10 intake form tests are xfail(strict=True). Regression test passes now.

Verified: uv run pytest -> 4 passed, 10 xfailed, 0 failed

Remove @pytest.mark.xfail decorators once all tests pass — do not modify the assertions.

---

Implementation instructions

1. Add jinja2>=3.1.0 to pyproject.toml and run uv sync
2. Create src/triage_assistant/api/templates/intake.html — all 6 HelpRequest fields with required attribute, noscript warning, vanilla JS fetch() POST to /triage
3. In main.py: mount Jinja2Templates + GET / route returning TemplateResponse
4. Remove all @pytest.mark.xfail decorators once tests pass

Do not change the POST /triage request/response schema. Data contract is locked per ADR-0005.

Design: docs/adr/ADR-0005-intake-form-templating.md

[Copilot]

Pull request overview

This PR sets up the test-first scaffolding for US-012 (a browser-based intake form for field contractors), adding a new ADR that selects Jinja2 templating with a JS fetch() submission strategy and a pytest module of xfail-marked behavioral tests against a future GET / route. Implementation files (intake.html, main.py route, pyproject.toml dependency) are deliberately deferred to a follow-up per the PR description.

Changes:

• Add ADR-0005 documenting the Jinja2 + vanilla fetch() decision and the locked HelpRequest/TriageResult data contract.
• Add tests/test_intake_form.py with 10 xfail(strict=True) async tests covering AC-1, AC-2, AC-4, AC-5 and a non-xfail /health regression test.
• Document an httpx.ASGITransport helper to bypass FastAPI lifespan startup in CI.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
docs/adr/ADR-0005-intake-form-templating.md	New ADR choosing Jinja2 + JS fetch() and locking the POST /triage contract.
tests/test_intake_form.py	New TDD test suite for GET / (xfail) plus a /health regression test.

Comments suppressed due to low confidence (2)

tests/test_intake_form.py:35

• All test functions in this file are declared async def, but none carry an @pytest.mark.asyncio (or anyio) marker, and there is no pyproject.toml/pytest.ini in the repo configuring asyncio_mode = "auto" or registering pytest-asyncio. Without that, plain pytest will not await the coroutines: it emits a PytestUnhandledCoroutineWarning and the tests do not actually execute the assertions. Combined with xfail(strict=True), this means once triage_assistant is importable, the xfail tests will likely flip to XPASS/ERROR rather than the intended "xfailed" state. Please add pytest-asyncio (or anyio) as a dev dependency and configure it (e.g. asyncio_mode = "auto" or per-test markers) so these async tests are actually driven.

async def _get(path: str) -> httpx.Response:
    async with httpx.AsyncClient(
        transport=httpx.ASGITransport(app=app), base_url="http://test"
    ) as client:
        return await client.get(path)

tests/test_intake_form.py:109

• response.text.count("required") >= 6 is a brittle proxy for "every input has the required attribute". The substring "required" can match unrelated copy in labels, error-message text, the <noscript> warning, JS validation strings, ADR comments, or even a CSS class. The assertion can pass without any input element actually having the required attribute, and conversely could fail in a perfectly valid template that happens to also use the word elsewhere. Consider parsing the HTML (e.g. with html.parser/BeautifulSoup) and asserting that each of the six named inputs/textareas carries the required attribute, or at minimum match required adjacent to each name="…" attribute.

    response = await _get("/")
    assert response.text.count("required") >= 6

[shawnewallace]

We will not be merging your solution to main. You should just keep in your team's branch.