security: add .gitignore, lockfile, and tighten envelope schema#2
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
security: add .gitignore, lockfile, and tighten envelope schema#2devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Add .gitignore to prevent accidental commits of secrets (.env, *.pem, *.key), node_modules, OS files, and editor artifacts - Add package-lock.json for reproducible builds and supply-chain safety - Tighten protocol envelope schema: - Set additionalProperties to false (prevent unexpected field injection) - Add date-time format constraint on created_at - Add minLength and pattern constraint on kind (lowercase dotted identifiers) Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses three security gaps found during a codebase audit:
1. Missing
.gitignore— accidental secret exposure riskNo
.gitignoreexisted, meaning.envfiles,*.pem/*.keyprivate keys,node_modules/, and editor artifacts could be committed. Added standard ignore rules covering secrets, dependencies, OS files, editor dirs, logs, and build output.2. Overly permissive protocol envelope schema
envelope.schema.jsonhad"additionalProperties": true, allowing arbitrary unexpected fields to pass validation — a payload injection vector when the schema is used for input validation.Also added missing constraints:
created_at: added"format": "date-time"(was unconstrained string — any value accepted)kind: added"minLength": 1and"pattern": "^[a-z][a-z0-9_.]*$"(was any string, including empty)3. Missing
package-lock.jsonAdded lockfile for reproducible builds and supply-chain integrity (no dependencies yet, but locks the package metadata).
Link to Devin session: https://app.devin.ai/sessions/674a63ce15e647f886e55d45d449999f
Requested by: @cemphlvn