Support limiting tls version - #463
Open
kajinamit wants to merge 1 commit into
Open
Conversation
kajinamit
force-pushed
the
tls-version
branch
3 times, most recently
from
August 6, 2026 02:42
d703a6c to
58c33c3
Compare
There was a problem hiding this comment.
Pull request overview
Adds support for constraining negotiated TLS protocol versions by exposing SSLContext.minimum_version / maximum_version through new _wrap_socket_sni() options.
Changes:
- Extend
_wrap_socket_sni()to accepttls_minimum_versionandtls_maximum_versionand apply them to the createdSSLContext. - Add unit tests covering the new TLS version limit parameters.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| amqp/transport.py | Adds optional args to set SSLContext.minimum_version / maximum_version when wrapping sockets. |
| t/unit/test_transport.py | Adds tests asserting the TLS version properties are set on the mocked SSL context. |
Suppressed comments (1)
t/unit/test_transport.py:710
- This comment mentions
tls_minimum_version, but the test is exercisingtls_maximum_version(and assertscontext.maximum_version).
# testing _wrap_socket_sni() with parameter tls_minimum_version
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The SSLContext object provides a few properties to limit supported TLS versions. Add new options to set these. Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SSLContext object provides a few properties to limit supported TLS versions. Add new options to set these.