Eliminate usage of 'return' in 'finally' blocks

[torarvid]

This change helps make the code compatible with Python 3.14, where 'return' in finally blocks is no longer allowed.

[Copilot]

Pull request overview

This PR refactors code to eliminate the use of return statements within finally blocks to ensure compatibility with Python 3.14, where this pattern will no longer be allowed. The changes affect exception handling and control flow in two critical modules.

Key changes:

• Removed finally block with return statement in billiard/pool.py:_ack() method and moved the conditional return logic outside the try-except block
• Refactored billiard/connection.py:_recv_bytes() to use deferred return/raise pattern instead of returning from finally block

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
billiard/pool.py	Simplified exception handling in _ack() by removing the finally block and moving the acknowledgment send logic after the try-except block
billiard/connection.py	Refactored Windows pipe connection's _recv_bytes() to store result and exception state variables, enabling return/raise after finally block completes

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[torarvid]

@auvipy Hi 👋🏻 Yes, my own analysis was that by catching BaseException, we would get similar behavior as before (since the return-in-finally before would also prevent BaseExceptions from propagating). The other option that Copilot suggests is IMO more correct. I only went for the BaseException route because I’m not familiar enough with this repo to change behavior «on my own» 😅

So these changes LGTM 👍🏼

[Nusnus]

Thank you!

Released:

• https://github.com/celery/billiard/releases/tag/v4.2.4
• https://pypi.org/project/billiard/4.2.4/#history