feat: add AWS Secrets Manager backend and TracingAuditLog#3
Merged
Conversation
Decouples SecretStore from AuditLog — backends no longer need to bundle both. Users pick each independently via Vault<K, S, A>. New crate: zerolease-store-aws-sm - SecretStore implementation backed by AWS Secrets Manager - Stores metadata in AWS tags so list() avoids N+1 GetSecretValue calls - delete() defaults to AWS's 30-day recovery window (configurable) - Handles "marked for deletion" secrets as not-found - batch_update() documents non-transactional behavior New in core crate: - TracingAuditLog: emit-only audit backend using tracing::info!() - Error::NotSupported variant for unsupported operations - Softened batch_update trait doc for non-transactional backends CI: OIDC auth for AWS, configurable test prefix, --no-fail-fast
ceejbot
force-pushed
the
feature/aws-sm-backend
branch
from
a6fa132 to
f6803aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #1 — extracts and improves the AWS Secrets Manager backend into the workspace structure from #2.
Architecture: decouple SecretStore from AuditLog
The
Vault<K, S, A>type parameters already support independent backend selection. This PR makes that explicit — store crates no longer need to bundle both traits.rusqliteRusqliteAuditLogaws-smTracingAuditLogpostgresPostgresAuditLogorTracingAuditLogNew crate:
zerolease-store-aws-smSecretStorebacked by AWS Secrets Managerzerolease:kind,zerolease:version, etc.) solist()avoids N+1GetSecretValuecallsdelete()defaults to AWS's 30-day recovery window; opt-inwith_force_delete()batch_update()documents non-transactional behavior (acceptable for DEK rotation)MetadataTagenum for type-safe tag key managementNew in core crate
TracingAuditLog: emit-only audit backend viatracing::info!(), query methods returnError::NotSupportedError::NotSupportedvariantbatch_updatetrait doc for backends without transaction supportCI improvements
ZEROLEASE_SM_TEST_PREFIX) scoped to IAM policy--no-fail-faston SM tests for better diagnosticsCloses #1
Test plan
cargo clippy --workspace --all-targetscleancargo test --workspace— 66 tests pass, 8 AWS integration tests ignored locally