Skip to content

Fix template cache bug and deal with lower case conventions #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshua-hampton merged 3 commits into from
Mar 20, 2026
Merged

Fix template cache bug and deal with lower case conventions #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95b7448
Missing slash
joshua-hampton Mar 20, 2026
5cf6709
Add basedir to default template
joshua-hampton Mar 20, 2026
38094a7
Deal with conventions being lower case
joshua-hampton Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions checksit/check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,9 +354,9 @@ def _get_ncas_specs(
template = "auto"
specs = None
# find appropriate specs depending on convention
if file_path.split(".")[-1] == "nc" and ":Conventions" in file_content.cdl:
if file_path.split(".")[-1] == "nc" and ":conventions" in file_content.cdl.lower():
conventions = (
file_content.cdl.split(":Conventions =")[1].split(";")[0].strip()
file_content.cdl.lower().split(":conventions =")[1].split(";")[0].strip()
)
# NCAS-GENERAL file
if any(
Expand All @@ -367,7 +367,7 @@ def _get_ncas_specs(
print("\nNCAS-AMOF file detected, finding correct spec files")
print("Finding correct AMOF version...")
version_number = (
conventions[conventions.index("NCAS-") :]
conventions[conventions.upper().index("NCAS-") :]
.split("-")[2]
.replace('"', "")
)
Expand Down Expand Up @@ -591,6 +591,9 @@ def check_file(
(
"Conventions" in file_content.global_attrs.keys() and
"ncas-" in file_content.global_attrs["Conventions"].lower()
) or (
"conventions" in file_content.global_attrs.keys() and
"ncas-" in file_content.global_attrs["conventions"].lower()
) or (
"XMP-photoshop:Instructions" in file_content.global_attrs.keys() and
"national centre for atmospheric science" in file_content.global_attrs["XMP-photoshop:Instructions"].lower()
Expand Down
4 changes: 2 additions & 2 deletions checksit/etc/checksit.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ rule_splitter = |
format_checks_dir = %(basedir)s/fmt_checks
excludes =
#global_attributes:creation_date global_attributes:version
default_template_cache_dir = %(basedir)stemplate-cache
default_template_cache_dir = %(basedir)s/data/template-cache
template_cache_dirs = template-cache other-cache
default_template = template-cache/ceda-base.yml
default_template = %(basedir)s/data/template-cache/ceda-base.yml
specs_dir = %(basedir)s/data/specs

[dataset:ukmo-assim]
Expand Down