Conversation
pateltisha24
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When beats are marked as unusable in the Beat Editor, the artifact count displayed in the Data Quality chart does not match the artifact markers shown in the Signal View.
This is caused by two bugs in callbacks.py:
The ends array was built using np.insert instead of np.append, causing segment boundaries to be mismatched when multiple unusable segments exist basically, artifact cleanup ran on the wrong index ranges.
data_edited was saved to disk before the unusable segment cleanup ran, so the chart and signal view were reading from two different states of the same data.
Fix:
Changed np.insert to np.append when constructing ends to correctly pair segment boundaries.
Moved data_edited.to_csv() to after the cleanup block so both views reflect the same state.
not done
Acceptance Criteria:
Artifact count in the Data Quality chart matches the artifact markers in the Signal View after marking beats as unusable
Segment boundaries are correctly paired when multiple unusable segments exist