FEAT: Add validation to TrianglePandas.rename. Also add tests to ensure cascading of rename to triangle.columns_label.

[genedan]

Closes #654. Partially addresses #655 regarding the columns_label issue.

[codecov]

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.10%. Comparing base (0341334) to head (08b7a95).
⚠️ Report is 20 commits behind head on master.

Files with missing lines	Patch %	Lines
chainladder/core/pandas.py	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
+ Coverage   85.05%   85.10%   +0.05%     
==========================================
  Files          85       85              
  Lines        4865     4868       +3     
  Branches      619      619              
==========================================
+ Hits         4138     4143       +5     
+ Misses        518      517       -1     
+ Partials      209      208       -1     

Flag	Coverage Δ
unittests	85.10% <88.88%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

can you please add a test for the new exception?

[genedan]

k, added a few tests cases (incorrect # columns, misspelled strings, incorrect integer supplied).

[henrydingliu]

thanks.

for clarity, this would resolve #655 but not #660?

[genedan]

Only part of #655. Both Triangle.columns_label and Triangle.origin_label were problematic since TrianglePandas.rename failed to update either attribute.

This PR solves cascading changes to Triangle.columns_label, but figuring out what to do with Triangle.origin_label is a bit trickier, since that information is not contained in the origin axis of the Triangle. I think we'll need to make an engineering choice on how to integrate Triangle.origin_label with the origin axis or at least have both the label and the axis associated with each other in some kind of composite data type. But anyhow, I plan for that to be in a future PR.

#660 remains open and is a separate issue.